Skip to content

Re-exposed access control level inheritance#13

Merged
NSFatalError merged 1 commit into
mainfrom
bugfix/restored-inherited-access-control-level-func
Aug 18, 2025
Merged

Re-exposed access control level inheritance#13
NSFatalError merged 1 commit into
mainfrom
bugfix/restored-inherited-access-control-level-func

Conversation

@NSFatalError

@NSFatalError NSFatalError commented Aug 18, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Added API to validate and clamp access control levels based on inheritance context and a maximum allowed level.
    • Expanded access level support to include package, public, and open.
    • For member inheritance, overly permissive levels are disallowed and may yield no modifier; peer inheritance remains unaffected.

  • Refactor

    • Streamlined access control resolution by delegating calculation to a single helper for clearer, more consistent behavior.

  • Chores

    • Tightened internal visibility of helper collections to reduce surface area.

@NSFatalError NSFatalError self-assigned this Aug 18, 2025
@coderabbitai

coderabbitai Bot commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors DeclBuilder to delegate inherited access control computation to a helper. Introduces a new public API on WithModifiersSyntax to compute/clamp access levels based on inheritance context and a maximum allowed. Tightens internal visibilities of helper collections and extends recognized access levels.

Changes

Cohort / File(s) Summary
Access control computation refactor
Sources/PrincipleMacros/Builders/Declarations/Common/DeclBuilder.swift		 Replaced inline logic for inheritedAccessControlLevel with a single call to a helper method, returning a TokenSyntax? directly.
WithModifiersSyntax enhancements & visibility tightening
Sources/PrincipleMacros/Syntax/Extensions/WithModifiersSyntax.swift		 Added public func accessControlLevel(inheritedBy:maxAllowed:) to validate/clamp access levels; restricted helper collections to fileprivate; expanded allowed levels (package/public/open).

Sequence Diagram(s)

sequenceDiagram
  participant Builder as DeclBuilder
  participant Syntax as Basic/WithModifiersSyntax
  Builder->>Syntax: accessControlLevel(inheritedBy:maxAllowed)
  Syntax-->>Builder: TokenSyntax? (clamped or nil)
  Builder->>Builder: Use result for modifier emission
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

In the warren of code, I hop with care,
Trimming modifiers, fresh spring air.
Open? Public? Package?—I choose the right key,
Clamp with a twitch, then let it be.
One call now guides the burrow’s flow—
Fewer tunnels, faster go! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ec4efb1 and fb13cea.

📒 Files selected for processing (2)
  • Sources/PrincipleMacros/Builders/Declarations/Common/DeclBuilder.swift (1 hunks)
  • Sources/PrincipleMacros/Syntax/Extensions/WithModifiersSyntax.swift (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/restored-inherited-access-control-level-func

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NSFatalError NSFatalError merged commit 8eccf67 into main Aug 18, 2025
6 of 8 checks passed
@NSFatalError NSFatalError deleted the bugfix/restored-inherited-access-control-level-func branch August 18, 2025 20:27
@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...Macros/Syntax/Extensions/WithModifiersSyntax.swift 0.00% 25 Missing ⚠️
...ros/Builders/Declarations/Common/DeclBuilder.swift 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot mentioned this pull request Nov 22, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@NSFatalError NSFatalError

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NSFatalError